Introduce API version namespaces and implement Gems::V2.info
#66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoroth
added a commit
to marcoroth/gem.sh
that referenced
this pull request
Aug 5, 2023
Addresses #2
marcoroth
added a commit
to marcoroth/gem.sh
that referenced
this pull request
Aug 5, 2023
Addresses #2
segiddins
approved these changes
Nov 16, 2023
simi
approved these changes
Nov 16, 2023
|
@marcoroth rebase should fix CI 🙏 |
|
Just rebased, Edit: Ah, I guess it's the test coverage, will add a test |
Feel free to ignore CodeClimate, but indeed specs are failing because of some method is missing coverage, but it fails hard because of probably some change in never simplecov. Repo is missing |
|
Added some tests to bring the coverage back up |
|
This one should be ready from my POV. |
|
Would love to see a new version released with this change! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the
V1andV2namespaces to handle both Rubygems.org APIs.My main motivation was to use the
/api/v2/rubygems/:gem/versions/:version.jsonendpoint with thegemsgem.The existing
Gems::Clientimplementation was moved into theV1namespace asGems::V1::Client. I created a newV2client asGems::V2::Clientwhich implements the above mentioned endpoint.The
Gems::Clientstill exists and inherits fromGems::V1::Clientto be backwards compatible.Also the class methods on
Gemsremain and delegate their methods to anGems::Client/Gems::V1::Clientinstance.Additionally all the
V1methods can also be accessed through theV1module (this might help with future deprecation):The
V2methods can only be accessed by explicitly calling them on theV2module:I introduced a
AbstractClientmixin to share the behavior between the class methods onGems,Gems::V1andGems::V2.Let me know if you have any feedback! Thank you!